Book excerpt: Reservoir quality is studied using a wide range of similar techniques in both sandstones and carbonates. Sandstone and carbonate reservoir quality both benefit from the study of modern analogues and experiments, but modelling approaches are currently quite different for these two types of reservoirs. There are many common controls on sandstone and carbonate reservoir quality, but also distinct differences due primarily to mineralogy. Numerous controversies remain including the question of oil inhibition, the key control on pressure solution and geochemical flux of material to or from reservoirs. This collection of papers contains case-study-based examples of sandstone and carbonate reservoir quality prediction as well as modern analogue, outcrop analogue, modelling and advanced analytical approaches.